Refactoring old code

Murilo Boareto Delefrate this article just gives us an example. Obviously, in a real world case, the algorithm would be complex and the variables could be used in other places along with the code.

Thank you Romeo! Glad you like it

I tend to disagree with you there Chris.

This book is specified on PHP, but the concept has some valid points.

https://adamwathan.me/refactoring-to-collections/

However: I might have better called this article: "Modernizing your code" instead of refactor

Chris Bongers

Let's look at the pros and cons of this modernising.

Pros:

• Uses modern technology, which is good, because... modern?
• Uses less lines of code.

Cons: Readability - in an ideal world everyone would be up to date with ES6, but in reality most people are wayyy behind. I bet if you took a survey of software developers and asked them if they knew what a for each does vs Object.Entries, you'd have a lot more that understand the former. If the goal is to have clear code with a low probability that someone else modifying the code will make a mistake, going will the former will be more likely to achieve that. It's much safer to go with the lowest common denominator.

Bugs - Every time you modify code, there is the potential to add new bugs to the software. You have to weigh up this risk vs the benefit of making the changes. Usually code changes are either making the code more efficient, easier to read, or adding some new feature, which trumps the risk of creating bugs.

Efficiency - map is less efficient than for each, so this code will most likely be slower

Time - This took some amount of time and thought to implement, and presumably test. Since the code produces the same outcome, the time could have been better spent on producing value.

Debugging - It's harder to debug your script since it's so condensed. The old one you can just set a breakpoint on the line you want to debug, the new one you have to set a breakpoint on the line you want to debug, then the subsection. (Support for this has only just been added to vscode, support in other IDEs might not be there)

Hey Kernel

I might have actually better called the article "Modernizing your code" since the refactor wasn't a hard need, the code is working as is, and nothing wrong with it.

This would just be the modern-day approach.

Hey Kevin that struggle is so real, my previous company had to support up to IE9

You don't have to write old code, you can use a JavaScript Compiler like https://babeljs.io/